Correct what the url option does and what the admin URL defaults to - #3474
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects 2 claims that the deployment guides in #3461 to #3465 showed to be wrong.
The
urlrow of the server configuration table said the option "also enables proxy support such as Apache or Nginx". It does not:urlis the address absolute URLs are built from, while trusting the headers a proxy adds is a separate option,proxy.koa. A reader who set onlyurlgot no header trust and no warning.The Dockerfile comment said that without
STRAPI_ADMIN_BACKEND_URL"the admin panel defaults to localhost:1337". It does not either:createAbsoluteUrlinpackages/core/admin/admin/src/render.tsfalls back towindow.location.originwhen the value is empty, so the admin panel calls the origin it is served from, which is the wanted behavior behind a proxy. Pinning the value at build time is what you do when the admin is served from a different origin than the API.Direct preview link 👉 here