Fix the word boundary probe in the Inki style linter - #3466
Merged
Conversation
The probe ran grep against /dev/null, which matches nothing and exits 1 on every platform, so the GNU branch was never taken. Linux fell through to the BSD-only [[:<:]] classes that GNU grep rejects, and the checks using them produced no output while their errors went to stderr. Probing with real input fixes the detection, which restores the easy-words, casual-language, multi-action-step, spelled-number and all-caps checks on Linux. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
pr: chore
source: repo
Collaborator
|
Thanks, good catch, highlights the importance on testing things on multiple OSes <3 |
pwizla
approved these changes
Sep 11, 2026
pwizla
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the word boundary probe in the inki style linter. It ran
grep -E '\b'against/dev/null, which matches nothing and exits 1 on every platform, so the GNU branch was never taken and Linux fell through to the BSD-only[[:<:]]classes that GNU grep rejects. The result was that the easy-words, casual-language, multi-action-step, spelled-number and all-caps checks silently produced no findings on Linux, with their errors going to stderr while the script still exited 0. Probing with real input fixes the detection. The script is not referenced by any workflow, so this changes only what/inki:style-checkand the style-checker agent report.