Fix the proxy header config keys and register nginx and toml code blocks - #3460
Merged
Conversation
The keys are server.proxy.ipHeader and server.proxy.maxIpsCount. They were documented as app.proxyIpHeader and app.maxIpsCount, which Strapi never reads, so anyone configuring header trust behind a proxy was setting an ignored option. Verified against packages/core/core/src/services/server/index.ts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Prism and the llms-code validator each keep their own language list, so a fence needs registering in both. Adding these lets the deployment guides fence proxy configuration examples with a real language. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
pr: chore
source: repo
The proxy and process manager guides repeat the same Strapi-side configuration: the public url, the proxy header options, the upload body limits, and the caveats that apply when several instances share a database. Extracting them means a correction lands once instead of in every guide. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the reverse proxy options in the server configuration documentation: the keys are
server.proxy.ipHeaderandserver.proxy.maxIpsCount, notapp.proxyIpHeaderandapp.maxIpsCount, which are read from a path Strapi ignores at runtime. It registersnginxandtomlas recognized code block languages in both the Prism configuration and the llms-code validator, since each keeps its own language list. It also adds 4 shared snippets covering the Strapi-side configuration the deployment guides have in common, so a correction to the public url, the proxy header options, the upload body limits, or the multi-instance caveats lands once instead of in every guide.