Repository navigation
fix(oxlint-config): pin cloud Node and Bun archive checksums and never time out dpkg - #175
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. ℹ️ Recent review info
📜 Recent review details
Walkthrough
Merge Risk:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 7 files. (1 skipped: 1… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly summarises the two main changes: pinned cloud Node and Bun archive checksums, and preventing dpkg from running within the network timeout. Description check The description lists tests that directly cover the changed cloud setup and installation behaviour. It is related to the changeset, although it does not state the test results. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 7 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bd014af9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… the offline install A local package archive is installed offline so dpkg and maintainer scripts never run under a network deadline, but its dependencies may not be in the archive cache, and the offline install then stops with "Unable to fetch some archives". The install now asks apt which downloads are missing (--print-uris contacts no server), fetches only those under the network deadline, and then installs offline.
# Conflicts: # packages/oxlint-config/src/cloud-setup.test.ts # packages/oxlint-config/src/toolchain-schema.ts # packages/oxlint-config/toolchain.json
…etup-hardening-5954ba
…cept repository runtime pins apt fails internally when --no-download meets a local archive, so local archives now take the same bounded --download-only step as indexed packages. The install that follows runs without a deadline only after --print-uris shows that nothing but local file: archives remains to fetch. The shared policy pins archives only for its own Node patch and Bun release. A repository on another accepted Node patch or a newer Bun declares that one release's amd64 and arm64 values in cloud.runtimeArchiveSha256; a release the shared policy pins cannot be repeated there. Generation takes the repository Bun its callers already resolve instead of reading packageManager again.
Checks run:
cd packages/oxlint-config && bun test src/cloud-setup.test.tscd packages/oxlint-config && bun test src/cloud-setup-regressions.test.tscd packages/oxlint-config && bun test src/cloud-setup-toolchains.test.tscd packages/oxlint-config && bun test src/cloud-setup-artifacts.test.ts