Repository navigation
Conversation
NodeEngine built the <id> -> JACK port (audio) and <id> -> display output
(video) lookups from every list under the node's mappings, inputs included.
Inputs reuse the outputs' <id> numbering and come after them, so input 0
overwrote output 0: an audio cue on output "<node>_0" was resolved to
system:capture_1, found no mixer input for it and played SILENT ("No valid
mixer inputs found for outputs: ['system:capture_1']"). Any node whose
mappings list audio inputs is affected; seen on dev.stagelab.coop
(default_mappings lists capture_1/2).
Only the "outputs" list feeds the lookups now.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickUp: 869fhghhe
Problem
NodeEnginebuilt its<id>→ JACK port lookup (audio) and<id>→ display output lookup (video) from every list under the node's mappings, inputs included.node_mappings["audio"]is[{"outputs": [...]}, {"inputs": [...]}]. Inputs reuse the outputs'<id>numbering and are read after them, so input 0 overwrote output 0.An audio cue on output
<node>_0was then resolved tosystem:capture_1, found no mixer input for it and played SILENT:This affects any node whose mappings list audio inputs. Seen on dev.stagelab.coop, whose
default_mappings.xmllistscapture_1/capture_2. Video has the same loop; it only bites when video inputs are listed.Change
Only the
outputslist feeds the two lookups.Test plan
arm_test's audio cues on output_0now wireoutport 0 → 0_mixer:input_1; no SILENT error