Repository navigation
Conversation
…eport RUNNING Since the engine waits for a player's "[OK] RUNNING!" line before wiring it (869fbyjzx) and gates wiring on the player's JACK ports, the log-only mocks made every audio arm on a mock box wait the full 14.5 s RUNNING timeout and log the cue as SILENT; arm_test on dev.stagelab.coop took ~30 s to arm instead of ~1 s, and every STOP re-arm paid it again. The mock mixer had no ports either, so its output wiring retried for ~10 s at node start. Both mocks now open the same JACK client and ports as the real binaries (Audio_Player-<uuid> with "outport 0"/"outport 1"; jack-volume's -c client with input_N/output_N) against the jackd-dummy server, and print the ready line. Without a JACK server they stay log-only OSC endpoints as before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickUp: 869fhghhe
Problem
On a mock box (
cuems-engine-mock, e.g. dev.stagelab.coop) every audio cue arm waited the full 14.5 s RUNNING timeout and logged the cue as SILENT. The engine waits for a player's[OK] RUNNING!line before wiring it (869fbyjzx) and then gates wiring on the player's JACK ports. The log-only mocks printed neither and registered no ports.arm_testtook ~30 s to arm instead of ~1 s, and every STOP re-arm paid the same again. The mock mixer had no ports either, so its output wiring retried for ~10 s at node start.Change (mock scripts only, nothing the real engine runs)
scripts/mock_jack.py: opens a JACK client with given port names and prints the ready line. With no JACK server (or nojackmodule) it logs a warning and the mock stays a log-only OSC endpoint, as before.mock_audioplayer: clientAudio_Player-<uuid>withoutport 0/outport 1, same names ascuems-audioplayer.mock_jack_volume: client named by-c, portsinput_1..N/output_1..N, same asjack-volume.Test plan
arm_testarms in ~2.5 s (was ~30 s), STOP re-arm ~0.4 s, no "never reported RUNNING",jack_lsp -cshows the players wired into0_mixer