Skip to content

chore: deprecate planName and version flags, remove planId validation - #1540

Open
SerseusWasTaken wants to merge 1 commit into
mainfrom
chore/deprecate-dsa-functions
Open

chore: deprecate planName and version flags, remove planId validation#1540
SerseusWasTaken wants to merge 1 commit into
mainfrom
chore/deprecate-dsa-functions

Conversation

@SerseusWasTaken

Copy link
Copy Markdown
Contributor

Description

Applied for logme,mariadb,opensearch,rabbitmq and redis

Relates to STACKITCLI-440

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTaken force-pushed the chore/deprecate-dsa-functions branch from 9aa4856 to f0a77f7 Compare August 18, 2026 13:07
@SerseusWasTaken
SerseusWasTaken force-pushed the chore/deprecate-dsa-functions branch from f0a77f7 to bb24a68 Compare August 18, 2026 13:15
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/logme/instance/create 62.64% (+1.10%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/logme/instance/update 59.57% (+0.63%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/create 63.33% (+1.11%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/update 58.70% (+0.63%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/opensearch/instance/create 62.92% (+1.12%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/opensearch/instance/update 60.42% (+1.04%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create 62.89% (+1.03%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update 59.57% (+0.63%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/redis/instance/create 62.50% (+1.04%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/redis/instance/update 58.70% (+0.63%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/errors 75.96% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logme/utils 32.00% (+5.33%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/utils 32.00% (+5.33%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/opensearch/utils 32.00% (+5.33%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils 32.00% (+5.33%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/redis/utils 32.00% (+5.33%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/logme/instance/create/create.go 62.64% (+1.10%) 91 57 (+1) 34 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/logme/instance/update/update.go 59.57% (+0.63%) 94 (-1) 56 38 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/create/create.go 63.33% (+1.11%) 90 57 (+1) 33 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/update/update.go 58.70% (+0.63%) 92 (-1) 54 38 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/opensearch/instance/create/create.go 62.92% (+1.12%) 89 56 (+1) 33 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/opensearch/instance/update/update.go 60.42% (+1.04%) 96 58 (+1) 38 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create/create.go 62.89% (+1.03%) 97 61 (+1) 36 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update/update.go 59.57% (+0.63%) 94 (-1) 56 38 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/redis/instance/create/create.go 62.50% (+1.04%) 96 60 (+1) 36 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/redis/instance/update/update.go 58.70% (+0.63%) 92 (-1) 54 38 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/errors/errors.go 75.96% (ø) 104 79 25
github.com/stackitcloud/stackit-cli/internal/pkg/services/logme/utils/utils.go 32.00% (+5.33%) 25 (-5) 8 17 (-5) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/utils/utils.go 32.00% (+5.33%) 25 (-5) 8 17 (-5) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/opensearch/utils/utils.go 32.00% (+5.33%) 25 (-5) 8 17 (-5) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils/utils.go 32.00% (+5.33%) 25 (-5) 8 17 (-5) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/redis/utils/utils.go 32.00% (+5.33%) 25 (-5) 8 17 (-5) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@SerseusWasTaken
SerseusWasTaken marked this pull request as ready for review August 18, 2026 13:23
@SerseusWasTaken
SerseusWasTaken requested a review from a team as a code owner August 18, 2026 13:23
@cgoetz-inovex

Copy link
Copy Markdown
Contributor

PR lgtm from a technical stand point.
Do we see any chance to improve the UX of the current solution?

Before:

Error: the provided instance plan is not valid.

You provided plan ID "ffffffff-ffff-ffff-ffff-ffffffffffff", which is invalid.

For more details on the available plans, run:
  $ stackit redis plans

After:

Error: create Redis instance: 400 Bad Request, status code 400, Body: {"error":"Provision failed. no service offering found for plan_id=ffffffff-ffff-ffff-ffff-ffffffffffff","description":""}

I've checked the redis api docs, but sadly the errors are not defined in the spec in a way we could reliably use here. But the "Before" error message is quite nice. It's formatted and also hints at redis plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants