Skip to content

docs(beta): NAT gap now carries the lab numbers - #86

Merged
frahlg merged 1 commit into
mainfrom
55-beta-nat-numbers
Aug 29, 2026
Merged

docs(beta): NAT gap now carries the lab numbers#86
frahlg merged 1 commit into
mainfrom
55-beta-nat-numbers

Conversation

@frahlg

@frahlg frahlg commented Aug 29, 2026

Copy link
Copy Markdown
Member

Netsim measured the matrix (#82, #84); the remaining gap is real-network data.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KeiotDVE94wEzvc7wcvm1y


Note

Low Risk
Documentation-only change to BETA.md with no runtime or security impact.

Overview
Updates the beta Known gaps section so reconnect/NAT coverage is described more accurately.

The old NAT and network numbers bullet (tuned timing, no published measurements) is replaced with Real-network numbers, which points readers to the Docker NAT matrix in netsim/results/results.md and cites lab attach (~0.2–1.3 s) and post-flip resume (~2.6 s direct / ~3.0 s over TURN). The gap is now framed as missing published data from real home, office, and cellular networks—not missing lab work.

Reviewed by Cursor Bugbot for commit 17dc9f0. Bugbot is set up for automated code reviews on this repo. Configure here.

Netsim (#82, #84) measured the matrix; the gap that remains is real-network
data, so say that instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KeiotDVE94wEzvc7wcvm1y
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T12:52:29.149922Z 17dc9f0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17dc9f05a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread BETA.md
Comment on lines +39 to +40
([netsim/results/results.md](netsim/results/results.md)) shows attach in
0.2–1.3 s and resume after a network flip in ~2.6 s direct / ~3.0 s over

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Label the attach figures as p50 values

The linked matrix does not show all attach measurements within 0.2–1.3 s: its flip-turn row records a 2,289 ms maximum. The stated range only matches the scenario p50 values after rounding, so presenting it as the unqualified attach range understates the observed latency; either identify these as p50s or extend the range to include the measured maximum.

Useful? React with 👍 / 👎.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Cursor Bugbot completed successfully and reported no issues that need human review. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@frahlg
frahlg merged commit afff69c into main Aug 29, 2026
5 checks passed
@frahlg
frahlg deleted the 55-beta-nat-numbers branch August 29, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant