Skip to content

Bug 5552: Buffer overflow when parsing deny_info NNN w/o URL (#2481) #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadij merged 1 commit into from
Sep 6, 2026
+6 −4
Merged

Bug 5552: Buffer overflow when parsing deny_info NNN w/o URL (#2481) #2487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/errorpage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,10 +581,12 @@ ErrorDynamicPageInfo::ErrorDynamicPageInfo(const int anId, const char *aName, co
filenameOrUri = page_name;
}

const auto looksLikeUrl = [](const char * const name) { return name && strchr(name, ':'); };

// Guessed uri, filename, or both values may be nil or malformed.
// They are validated later.
if (!page_redirect) {
if (filenameOrUri && strchr(filenameOrUri, ':')) // looks like a URL
if (looksLikeUrl(filenameOrUri))
uri = filenameOrUri;
else
filename = filenameOrUri;
Expand Down Expand Up @@ -617,15 +619,15 @@ ErrorDynamicPageInfo::ErrorDynamicPageInfo(const int anId, const char *aName, co
// out of range
debugs(0, DBG_CRITICAL, "FATAL: status " << info->page_redirect << " is not valid on '" << page_name << "'");
self_destruct();
} else if ( /* >= 200 && */ info->page_redirect < 300 && strchr(&(page_name[4]), ':')) {
} else if ( /* >= 200 && */ info->page_redirect < 300 && looksLikeUrl(filenameOrUri)) {
// 2xx require a local template file
debugs(0, DBG_CRITICAL, "FATAL: status " << info->page_redirect << " requires a template on '" << page_name << "'");
self_destruct();
} else if (info->page_redirect >= 300 && info->page_redirect <= 399 && !strchr(&(page_name[4]), ':')) {
} else if (info->page_redirect >= 300 && info->page_redirect <= 399 && !looksLikeUrl(filenameOrUri)) {
// 3xx require an absolute URL
debugs(0, DBG_CRITICAL, "FATAL: status " << info->page_redirect << " requires a URL on '" << page_name << "'");
self_destruct();
} else if (info->page_redirect >= 400 /* && <= 599 */ && strchr(&(page_name[4]), ':')) {
} else if (info->page_redirect >= 400 /* && <= 599 */ && looksLikeUrl(filenameOrUri)) {
// 4xx/5xx require a local template file
debugs(0, DBG_CRITICAL, "FATAL: status " << info->page_redirect << " requires a template on '" << page_name << "'");
self_destruct();
Expand Down
Loading