Repository navigation
perf: pin polyglot with faster column qualification - #923
Merged
Merged
Conversation
…ented set operations Bump polyglot-sql to a revision that borrows source column sets during schema-aware column qualification, so wide relations and SELECT * over derived tables qualify in linear time, and that builds scopes for set-operation chains with comments before the operators in linear time. Analysis results are unchanged. Extend the long UNION ALL fixture guard with an input fixture whose rows are separated by a comment before each UNION ALL; 200-row commented fixtures previously took about 17 times as long as 50-row fixtures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Polyglot's column qualification cloned source column sets per column reference and built a full scope tree under each SELECT, so wide joins and wide
SELECT *subqueries analysed slowly. CommentedUNION ALLchains were still quadratic (CHI-450, CHI-478).Changes
polyglot-sqlto perf: borrow source column sets in qualification; linear scopes for commented set operations polyglot#33: borrowed column sets in qualification, and linear scopes for commented set operations.UNION ALLfixture performance guard gains a commented-fixture case.Verification
make test,make check-ci.