Repository navigation
build: align the polyglot Python wheel with the Rust crate revision - #1017
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The native extension built Polyglot from revision
9ff0af28(crate 0.13.8), while the Python path used thepolyglot-sql-chio0.13.8 wheel, which was released two commits earlier and lacks sqlstack-io/polyglot#32 (set operations after subquery operands stay at the outer query) and #33 (borrowed source column sets in qualification). The two engines analysed SQL with different Polyglot code.Changes
ca9e7b6e(9ff0af28plus a version-only bump), taggedpython-v0.13.9and published to PyPI.polyglot-sql-chiopinned to 0.13.9 and the Cargopolyglot-sql/polyglot-sql-function-catalogsrev moved toca9e7b6e, so the wheel and the crate come from the same commit. Lockfiles updated.Verification
uv lock --check --python 3.12andmake check-cipass.make test: 11,634 passed; one timing-sensitive event-dispatcher test failed under full-suite load and passed 3/3 in isolation (unrelated to SQL analysis).make compiler-differential(168 projects, python vs native-preview) andmake compiler-differential-shipped(162 projects, python vs native) report all projects identical.