Repository navigation
fix: keep set operations after a parenthesized FROM subquery at the outer query - #35
Merged
Merged
Conversation
…uter query A parenthesized query in FROM absorbed a following UNION/INTERSECT/EXCEPT, so `SELECT * FROM (SELECT ...) UNION ALL SELECT ...` parsed as `SELECT * FROM ((SELECT ...) UNION ALL SELECT ...)`. A parenthesized FROM query now continues into a set operation only where it opens an enclosing parenthesis, as in `FROM ((SELECT 1) UNION (SELECT 2))`, matching the expression-operand rule. The wrapper-normalization test now starts from an explicitly wrapped set operation, since the unwrapped query no longer parses as one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
FROMwas absorbed into that subquery:SELECT * FROM (SELECT 1 AS x) UNION ALL SELECT 2parsed with theUNION ALLinside the FROM operand, so downstream tools reported false column-count errors and mis-formatted the query. fix: keep set operations after subquery operands at the outer query; build set-operation scopes in linear time #32 fixed the same shape for subqueries in expressions; this covers FROM.Changes
fix:a bracketed query inFROMtakes a following set operation only when its bracket opens an enclosing one, as inFROM ((SELECT 1) UNION (SELECT 2)), matching the rule from fix: keep set operations after subquery operands at the outer query; build set-operation scopes in linear time #32.test_can_disable_set_operation_wrapper_normalizationrelied on the old mis-parse; its input is now an explicitly wrapped set operation.Verification