Repository navigation
perf: run semantic validation on the shared scope tree - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Semantic validation rebuilt work that analysis and its own reference pass had already done: a scope tree per SELECT for the semantic checks, SELECT copies to strip WITH clauses, repeated whole-tree walks, and a deep comparison of whole derived-table queries per column lookup. On a 3,000-model project this roughly tripled native analysis time.
Changes
Verification
cargo test --lib -p polyglot-sql: 1343 passed;make test-rust-feature-gatesandmake check-consistencypass; query-analysis, regression and type-truth suites pass (the existinganalyze_query_set_operation_name_alignment_and_cast_consensus_454failure on main is unchanged).