Repository navigation
fix: reject bracketed DuckDB keyword time functions - #30
Merged
Merged
Conversation
0.13.4 registered DuckDB's keyword time functions as zero-argument catalog functions so the bare keyword forms validate, which also accepted CURRENT_TIMESTAMP(), current_time(), localtime() and localtimestamp(). DuckDB rejects those calls. Report the bracketed forms as unknown functions and keep the keyword forms valid. Bump to 0.13.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
0.13.4 registered DuckDB's keyword time functions (
current_time,current_timestamp,localtime,localtimestamp) as zero-argument catalog functions so their bare keyword forms validate. That also madeCURRENT_TIMESTAMP()and the other bracketed forms valid, but DuckDB 1.5.2 rejects them ("Scalar Function with name current_timestamp does not exist!").Changes
Verification
cargo test --lib -p polyglot-sql: 1341 passed;make test-rust-feature-gatespassed; the new test fails without the fix.