Improvement to the shell component

[Corentin755727]

ability to separate menu items with a divider bar

json('[{
            "component": "shell",
            "title": "SQLPage: SQL websites",
            "icon": "database",
            "link": "/",
            "menu_item": [
                {"title": "Home", "active": true},
                {"divider": true},
                {"title": "About"}
            ]
        }]'))

[lovasoa]

Hello @Corentin755727 , and welcome to SQLPage ! I think you forgot to commit the actual implementation of the divider in the shell component :) Or did you mean to open a feature request instead of a pull request ?

[Corentin755727]

Hello, I indeed forgot to include the main file in the commit. I’ve added it in commit dc81c8f.

[lovasoa]

You may have a formatting issue ? Github shows every single line in the shell handlebars file as changed

[Corentin755727]

Yes, copying the file completely changed its formatting, but only lines 126 and 127 were actually modified.

In the original file :

126                                    {{~#each this.submenu~}}
127                                        {{#if (or (or this.title this.icon) this.image)}}

In the new file :

126                                    {{~#each this.submenu~}}
127                                        {{~#if this.divider}}
128                                            <hr class="dropdown-divider" />
129                                        {{~else if (or (or this.title this.icon) this.image)}}

I apologize for the inconvenience caused by my commits.

[kryskool]

Hi @lovasoa

i think the ident problem come from windows, to prevent this i always defined on the .gitattributes the end of line for each type of file.

https://docs.github.com/fr/get-started/git-basics/configuring-git-to-handle-line-endings#per-repository-settings

Regards,