Skip to content

refactor(frontend) :: enable noImplicitAny - #1517

Draft
81reap wants to merge 1 commit into
mainfrom
81reap/ts-12-noImplicitAny
Draft

81reap wants to merge 1 commit into
mainfrom
81reap/ts-12-noImplicitAny

Conversation

@81reap

@81reap 81reap commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

noImplicitAny is now enabled.

Most of the remaining implicit workarounds rooted from JSON.parse(data_element.textContent).

This found 3 bugs due to as ChartPoint ::

  1. ChartPoint.x excluded null, z was a number, and y excluded the string[] two value columns return.
  2. ChartSeries.name was a string, and the test pinning a numeric series name has passed all along.
  3. merged_x_values compares x values that may be null, which JavaScript reads as zero.

Most remaining work arounds we should step back and think big about if we need to upstreaming patches along with the fixes.


Stack created with GitHub Stacks CLI • Give Feedback 💬

@81reap
81reap added this pull request to stack #1512 September 30, 2026 04:15
@lovasoa
lovasoa force-pushed the 81reap/ts-12-noImplicitAny branch 2 times, most recently from 2af515b to 3ee3636 Compare September 30, 2026 19:44
@81reap
81reap force-pushed the 81reap/ts-12-noImplicitAny branch from 3ee3636 to 25669f0 Compare September 30, 2026 21:24
@81reap

81reap commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@81reap 81reap linked an issue Oct 1, 2026 that may be closed by this pull request
Base automatically changed from 81reap/ts-11-any-apexcharts to main October 1, 2026 06:59
`noImplicitAny` is now enabled.

Most of the remaining implicit workarounds rooted from `JSON.parse(data_element.textContent)`.

This found 3 bugs due to `as ChartPoint` ::
1. `ChartPoint.x` excluded null, `z` was a number, and `y` excluded the `string[]` two `value` columns return.
2. `ChartSeries.name` was a string, and the test pinning a numeric series name has passed all along.
3. `merged_x_values` compares x values that may be null, which JavaScript reads as zero.

Most remaining work arounds we should step back and think big about if we need to upstreaming patches along with the fixes.
@lovasoa
lovasoa force-pushed the 81reap/ts-12-noImplicitAny branch from 25669f0 to f4bd4ec Compare October 1, 2026 06:59
@lovasoa

lovasoa commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Thank you very much for this work ! You did well. I have always tried to open patches upstream (so that they benefit all the users of our dependencies) rather than include workarounds in SQLPage. We are not under pressure here, so we have the time to do things well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to a better type system

2 participants