refactor(chart) :: import and use 3rd party ApexCharts types - #1516
Merged
Merged
Conversation
81reap
added this pull request to stack #1512
September 30, 2026 00:38
lovasoa
force-pushed
the
81reap/ts-11-any-apexcharts
branch
2 times, most recently
from
September 30, 2026 19:44
f7c358f to
2c3708a
Compare
`apexcharts.ts` now has one implicit any, `TooltipArgs` keeps its `w: any` until upstream ApexCharts updates it's tooltip types. Fixing this smoked out six workarounds :: 1. `options as ApexOptions` hid that `zaxis` is not an ApexCharts option at all. 2. `yasix` has to be normalized into an array and forwarded within `bubbleTooltip`. Now `chartTooltip` takes the axis titles directly. 3. `formatTooltipX` returned a value where `tooltip.x.formatter` is declared to return a `string`. 4. pie `labels` were `(string | number)[]` where `ApexOptions` wants `string[]`. 5. `xaxis.tickAmount` was assigned after the literal instead of inside it. 6. the `dataLabels` formatters destructured an `opts` that ApexCharts declares optional, so they are now three named functions.
81reap
force-pushed
the
81reap/ts-11-any-apexcharts
branch
from
September 30, 2026 21:24
2c3708a to
cd5dda6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apexcharts.tsnow has one implicit any,TooltipArgskeeps itsw: anyuntil upstream ApexCharts updates it's tooltip types.Fixing this smoked out six workarounds ::
options as ApexOptionshid thatzaxisis not an ApexCharts option at all.yasixhas to be normalized into an array and forwarded withinbubbleTooltip. NowchartTooltiptakes the axis titles directly.formatTooltipXreturned a value wheretooltip.x.formatteris declared to return astring.labelswere(string | number)[]whereApexOptionswantsstring[].xaxis.tickAmountwas assigned after the literal instead of inside it.dataLabelsformatters destructured anoptsthat ApexCharts declares optional, so they are now three named functions.Stack created with GitHub Stacks CLI • Give Feedback 💬