fix(frontend) :: remove any types from sqlpage.ts - #1515
Merged
Merged
Conversation
81reap
added this pull request to stack #1512
September 30, 2026 00:38
lovasoa
force-pushed
the
81reap/ts-10-any-sqlpage
branch
from
September 30, 2026 12:47
9d32905 to
94c4f70
Compare
`sqlpage.ts` now has no implicit anys. Fixing this smoked out two bugs :: 1. `init_bootstrap_components` read `event.target` without knowing what kind of element. We also tighting scope from `Element` to `HTMLElement`. 2. `normalize_hash` passed `undefined` to `decodeURIComponent`, which stringifies it, so a toast with no `data-toast-trigger` opened at `#undefined`.
lovasoa
force-pushed
the
81reap/ts-10-any-sqlpage
branch
from
September 30, 2026 19:44
94c4f70 to
420c953
Compare
lovasoa
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlpage.tsnow has no implicit anys.Fixing this smoked out two bugs ::
init_bootstrap_componentsreadevent.targetwithout knowing what kind of element. We also tighting scope fromElementtoHTMLElement.normalize_hashpassedundefinedtodecodeURIComponent, which stringifies it, so a toast with nodata-toast-triggeropened at#undefined.Stack created with GitHub Stacks CLI • Give Feedback 💬