refactor(map) :: import and use 3rd party Leaflet types - #1514
Merged
Merged
Conversation
81reap
added this pull request to stack #1512
September 29, 2026 23:31
81reap
force-pushed
the
81reap/ts-9-leaflet-types
branch
from
September 30, 2026 00:19
03d2ac7 to
c0b378d
Compare
81reap
force-pushed
the
81reap/ts-9-leaflet-types
branch
2 times, most recently
from
September 30, 2026 00:38
c7bd3da to
03d2ac7
Compare
`chart.handlebars` emits 6 keys for a reference line and stringifies so that unset fields come in as null. This is now explictly set in the type by making it a `Record`.
`declare const L: Untyped` meant every Leaflet value in sqlpage_map was typed `any`. Now we import `@types/leaflet` and use the types in SQLPage.
lovasoa
force-pushed
the
81reap/ts-9-leaflet-types
branch
from
September 30, 2026 12:47
03d2ac7 to
c91e5a2
Compare
lovasoa
approved these changes
Sep 30, 2026
lovasoa
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
declare const L: Untypedmeant every Leaflet value in sqlpage_map was typedany.Now we import
@types/leafletand use the types in SQLPage.Stack created with GitHub Stacks CLI • Give Feedback 💬