fix(chart) :: use typed Map instead of Object.prototype - #1510
Merged
Merged
Conversation
81reap
added this pull request to stack #1512
September 29, 2026 03:56
lovasoa
approved these changes
Sep 29, 2026
lovasoa
force-pushed
the
81reap/ts-7
branch
from
September 29, 2026 04:43
fadd6ac to
86a32c8
Compare
lovasoa
force-pushed
the
81reap/ts-7
branch
from
September 29, 2026 12:23
9ef9451 to
0199e60
Compare
81reap
force-pushed
the
81reap/ts-7
branch
2 times, most recently
from
September 29, 2026 22:52
b9e646b to
529cb28
Compare
lovasoa
force-pushed
the
81reap/ts-7
branch
from
September 29, 2026 23:22
529cb28 to
7cbaebc
Compare
lovasoa
approved these changes
Sep 29, 2026
Before loosly typed `Object.protoype` was used to map user inputs to built in properties. This is what a `Map` is supposed to do, so we use that with stong types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before loosly typed
Object.protoypewas used to map user inputs to built in properties.This is what a
Mapis supposed to do, so we use that with stong types.Stack created with GitHub Stacks CLI • Give Feedback 💬