Repository navigation
Conversation
…dule identifiers. Signed-off-by: 안승현 <abeb3@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1962.
HasMigrationFilesfilters application modules before their Flyway locations are constructed. For a dotted identifier such asfully.qualified, it currently searchesdb/migration/fully.qualified, although the existing location customizer converts the identifier todb/migration/fully/qualified. The module can therefore be discarded before that correctly constructed location is used.Apply the same dot-to-slash conversion in the migration-file check. This keeps discovery consistent with the existing location construction and limits the change to the filter.
The regression test places a migration resource under
db/migration/fully/qualifiedand expects both the root and module configurations, with the module location set toclasspath:db/migration/fully/qualified. Before the fix, the module is filtered out and only the root configuration remains. This test checks resource discovery and location configuration; it does not execute SQL migrations.Validation on Windows with Oracle JDK 17.0.12:
clean verifywith-faeand build caching disabled failed in 6 existing JDBCfindsPublicationsOlderThanReferenceassertions for Oracle and SQL Server (expected 1 result, got 2). Maven skipped 8 dependent modules. Those failures were not compared against an unchanged base branch.