Mark starter jars as Spring-Boot-Jar-Type: dependencies-starter

[spencergibb]

Add Spring-Boot-Jar-Type: dependencies-starter to manifest.

spring-projects/spring-boot#22036

spring-projects/spring-boot@fa1d4a4

/cc @wilkinsona

I'm hoping we can configure things here so starter poms have minimal if any changes.

[spencergibb]

Manifest currently looks like

Manifest-Version: 1.0
Implementation-Title: Spring Cloud Starter Netflix Eureka Client
Implementation-Version: 3.0.0-SNAPSHOT
Build-Jdk-Spec: 1.8
Created-By: Maven Jar Plugin 3.2.0
Implementation-Vendor: Pivotal Software, Inc.

Current maven plugin configuration

<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-jar-plugin</artifactId>
	<version>${maven-jar-plugin.version}</version>
	<configuration>
		<archive>
			<manifest>
				<mainClass>${start-class}</mainClass>
				<addDefaultImplementationEntries>true
				</addDefaultImplementationEntries>
			</manifest>
		</archive>
	</configuration>
</plugin>

Put the configuration in a profile that is active if a property is set and then we'd only have to set that property in the starter poms. Does that sound reasonable @marcingrzejszczak?

[spencergibb]

https://maven.apache.org/shared/maven-archiver/examples/manifestEntries.html

[david-vana]

@spencergibb The above described solution with property-based profile activation will not work. Maven profile activation works with the system property - not with the Maven POM property.

I found just these options:

• implement a plugin similar to this one used in Spring Boot project
• create a specific parent pom for starters with maven-jar-plugin configuration adding a manifest entry
• manually add a manifest entry to each starter pom

What would you prefer? I'd be happy to prepare a pull request.