Federation: Opensearch integration, federation init optimization, and P2P testing set-up - #331
Open
klpoland wants to merge 20 commits into
Open
Federation: Opensearch integration, federation init optimization, and P2P testing set-up#331klpoland wants to merge 20 commits into
klpoland wants to merge 20 commits into
Conversation
klpoland
changed the title
klpoland
added
documentation
klpoland
marked this pull request as ready for review
August 5, 2026 16:49
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Use the installed package path, coerce OpenSearch client settings types, and align deptry ignores with the shared client move. Co-authored-by: Cursor <cursoragent@cursor.com>
klpoland
force-pushed
the
feature-kpoland-federation-opensearch-integration
branch
from
August 13, 2026 13:58
8a67d90 to
c9abc50
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6d9a703. Configure here.
| "verify_certs": verify_certs, | ||
| "ssl_show_warn": False, | ||
| "connection_class": RequestsHttpConnection, | ||
| } |
There was a problem hiding this comment.
Empty OpenSearch auth always sent
High Severity
build_opensearch_client always sets http_auth via HTTPBasicAuth, even when user and password are empty. Federation previously constructed the client with no auth. Peer compose sets blank OpenSearch credentials with security disabled, so requests now send an empty Basic Authorization header and can fail against unauthenticated OpenSearch.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 6d9a703. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
- Federation indices schema specification
- Common Opensearch client and query methods (move out of gateway)
- peer-to-peer test config
- more just recipes for local deployment and testing
- troubleshooting and bug-fixing fed init
- GitHub actions to run pre-commit hooks and tests on federation app
- Federated search
- Integrate peer datasets into web UI views for public datasets (home and published search)
- Clean up old, unused code
Note
Medium Risk
Changes federation indexing, peer identity (FQDN), and Docker build context for gateway/federation images—incorrect deploy or site_name mismatch could break sync or search, but scope is mostly shared libraries and test/ops tooling with regression tests added.
Overview
Introduces
common/sds-opensearch-query(sds-opensearch-query) with shared OpenSearch client, fed-* index mappings/writes, query helpers, and Redis federation channel naming. Federation sync and gateway both depend on it; federation consolidates indexing/listing intofed_index, ensuresfed-*indices on startup, and drops the separatefed_searchmodule.Federation identity and sync behavior now treat OpenSearch
site_nameand webhook allowlists as peer FQDNs (not short[site].name), with bootstrap/backfill and Redis payloads aligned. Site-hello backfill runs in the background with retries on peerlist-*calls; peer HTTP goes throughpeer_http. Federated doc schemas allow extra gateway fields andsearch_propson captures.Build/CI: repo-root
.dockerignore, gateway/federation Docker/Compose buildcontext: .., newfederation-checksworkflow (prek + pytest), and gateway workflow image build context update.Local/remote P2P testing:
compose.peer.local.yaml,compose.peer.remote.yaml, deploy/seed/verify scripts, README and peer-remote docs; compose env shifts towardfederation-shared.env+ gateway OpenSearch env instead of federation-only sync env files.Reviewed by Cursor Bugbot for commit 6d9a703. Bugbot is set up for automated code reviews on this repo. Configure here.