Repository navigation
Add --exclude to mps-check-orphan-modules and mps-check-orphan-models - #10
Merged
Merged
Conversation
Both hooks scan the whole repository, so prek's and pre-commit's exclude: has no effect on them. A repeatable --exclude=GLOB option, matched against the repository-relative path of the module descriptor or model file, lets a project with existing orphans enable the hooks and still catch new ones. Closes #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9.
mps-check-orphan-modulesandmps-check-orphan-modelsscan the whole repository (pass_filenames: false), so prek's or pre-commit'sexclude:has no effect on them. This adds a repeatable--exclude=GLOBoption to both, the same as inmps-check-unbuilt-modulesandmps-check-empty-model-roots..gitignore-style and is matched against the repository-relative path of the module descriptor (orphan-modules) or the model file (orphan-models). A trailing/excludes a subtree.main(argv)/parse_args, like the other hooks..pre-commit-hooks.yamldescriptions andCHANGELOG.mdupdated.Example: