Repository navigation
fix: expand Windows %IDE_HOME% in MPS bootstrap JVM arguments - #112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, MPS 2026.2's
product-info.jsondeclares-Xbootclasspath/a:%IDE_HOME%/lib/nio-fs.jar. The daemon launcher only expanded$IDE_HOME, so the daemon started withoutnio-fs.jaron the boot classpath and failed withNoClassDefFoundError: com/intellij/platform/core/nio/fs/MultiRoutingFileSystem.mpsBootstrapJvmArgs(mpsHome) for each additionalJvmArgument of the host launch entry + replace "%IDE_HOME%" with mpsHome replace "$IDE_HOME" with mpsHomeThe argument is passed to the daemon JVM as its own
ProcessBuilderlist element, so an MPS home with spaces needs no extra quoting.Fixes #111.
Evidence
Before: the new test
bootstrap classpath resolves Windows IDE home placeholder in a path with spacesfails. It uses a Windows launch entry, OS nameWindows 11, and the MPS homeProgram Files/JetBrains/MPS 2026.2, and expects-Xbootclasspath/a:<mps home>/lib/nio-fs.jar. The launcher returns the argument with%IDE_HOME%unexpanded.After: the test passes, and the existing macOS
$IDE_HOMEtest still passes. The full./gradlew checkpasses.Tested on macOS only, not on real Windows.
Merge Danger
Blast Radius: small. It changes only the bootstrap JVM arguments of daemons started from an MPS home that has a
product-info.json.