fix(styles/webidl): add dark mode color variants for contrast - #5286
Draft
marcoscaceres wants to merge 1 commit into
Draft
fix(styles/webidl): add dark mode color variants for contrast#5286marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
Add prefers-color-scheme: dark overrides for WebIDL syntax colors. The hardcoded dark-blue (#005a9c) and orangered (#ff4500) have poor contrast on dark backgrounds. The header badge also gets a darker blue background with light text. Partially addresses #4871
Contributor
There was a problem hiding this comment.
Pull request overview
Adds dark-mode-specific WebIDL syntax colors to improve contrast when prefers-color-scheme: dark is active, partially addressing the contrast problems described in #4871.
Changes:
- Introduces a
@media (prefers-color-scheme: dark)block for WebIDL header and token colors. - Adjusts link and enum item styling (text + underline/border colors) for better readability on dark backgrounds.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+141
to
+144
| .idlHeader { | ||
| background: #1a5276; | ||
| color: #e8e8e8; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #4871
Add prefers-color-scheme: dark overrides for WebIDL syntax colors
that have poor contrast on dark backgrounds.
Written with AI: this change was generated by Claude. Per AI_POLICY.md.