Repository navigation
Conversation
git apply uses the first encoded section as the forward result, so leaving the sections in the original order makes the reversed patch fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReverseFileDiffswaps theindexhashes and thediff --gitpaths. AGIT binary patchstill keeps its two encoded sections in the original order.git applyuses the first section as the forward result and the second as the reverse result.git diff -R --binarywrites them in the opposite order. With only the hashes swapped,git apply --checkreportscreates incorrect resultand the file is left unchanged.The two sections are now swapped. A literal patch and a delta patch both reverse. On the reported
bin.datpatch,git applyof the reversed diff turns00 01 02 03back into00 01.go test -count=1 ./diff/passed. Before the swap,TestReverseFileDiffGitBinarySemanticsstill hadliteral 4ahead ofliteral 2.Fixes #98