Skip to content

πŸ’„ μ‹€μ‹œκ°„ 인기 νŒŒκ²¬ν•™κ΅ μΉ΄λ“œ 이미지 ν•˜λ‹¨ κ·ΈλΌλ°μ΄μ…˜ μΆ”κ°€ - #610

Merged
manNomi merged 3 commits into
mainfrom
fix/current-term-empty-universities
Jul 25, 2026
Merged

manNomi merged 3 commits into
mainfrom
fix/current-term-empty-universities

Conversation

@manNomi

@manNomi manNomi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Figma λ…Έλ“œ 4265:39768 (Rectangle 3416) μ—μ„œ linear gradient 값을 μΆ”μΆœν•˜μ—¬ PopularUniversityCard λŒ€ν•™κ΅ 이미지 ν•˜λ‹¨μ— κ·ΈλΌλ°μ΄μ…˜ μ˜€λ²„λ ˆμ΄ 반영

λ³€κ²½ λ‚΄μš©

apps/web/src/app/(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx

  • 이미지 μ»¨ν…Œμ΄λ„ˆ 내뢀에 absolute inset-0 gradient overlay div μΆ”κ°€

Figma 기반 κ·ΈλΌλ°μ΄μ…˜ κ°’ (λ…Έλ“œ 4265:39770)

linear-gradient(
  to bottom,
  rgba(255, 255, 255, 0) 0%,
  rgba(0, 0, 0, 0.35) 75%,
  rgba(0, 0, 0, 0.70) 100%
)

Test plan

  • ν™ˆ ν™”λ©΄ > μ‹€μ‹œκ°„ 인기 νŒŒκ²¬ν•™κ΅ μΉ΄λ“œ 이미지 ν•˜λ‹¨μ— κ·ΈλΌλ°μ΄μ…˜μ΄ μžμ—°μŠ€λŸ½κ²Œ μ μš©λ˜λŠ”μ§€ 확인
  • λŒ€ν•™κ΅ 이름 ν…μŠ€νŠΈ 가독성 ν–₯상 확인
  • λ°°κ²½ 이미지 placeholder μƒνƒœμ—μ„œλ„ 정상 ν‘œμ‹œ 확인

πŸ€– Generated with Claude Code

@manNomi
manNomi requested a review from wibaek as a code owner July 24, 2026 04:56
@vercel

vercel Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jul 24, 2026 8:59am
solid-connect-web-admin Ready Ready Preview, Comment Jul 24, 2026 8:59am
solid-connection-web Ready Ready Preview, Comment Jul 24, 2026 8:59am

@github-actions github-actions Bot added the web label Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bcc6d570-01d5-4de4-837f-f32773d21ce3

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between b2128f3 and 3063004.

β›” Files ignored due to path filters (2)
  • docs/screenshots/gradient-after.png is excluded by !**/*.png
  • docs/screenshots/gradient-before.png is excluded by !**/*.png
πŸ“’ Files selected for processing (1)
  • apps/web/src/app/(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/src/app/(home)/_ui/PopularUniversitySection/_ui/PopularUniversityCard.tsx

Walkthrough

1. **λ°°κ²½ κ·ΈλΌλ””μ–ΈνŠΈ μ˜€λ²„λ ˆμ΄ μΆ”κ°€**  
인기 λŒ€ν•™ μΉ΄λ“œμ˜ λ°°κ²½ 이미지 ν•˜λ‹¨ μ ˆλ°˜μ— μ ˆλŒ€ μœ„μΉ˜ μ„ ν˜• κ·ΈλΌλ””μ–ΈνŠΈ λ ˆμ΄μ–΄λ₯Ό μΆ”κ°€ν•΄ μ•„λž˜λ‘œ 갈수둝 μ–΄λ‘μ›Œμ§€λ„λ‘ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: wibaek

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed 제λͺ©μ΄ PopularUniversityCard 이미지 ν•˜λ‹¨ κ·ΈλΌλ°μ΄μ…˜ μΆ”κ°€λΌλŠ” 핡심 변경을 λͺ…ν™•νžˆ λ‹΄κ³  μžˆμŠ΅λ‹ˆλ‹€.
Description check βœ… Passed μš”μ•½, λ³€κ²½ λ‚΄μš©, ν…ŒμŠ€νŠΈ κ³„νšμ΄ κ°–μΆ°μ Έ μžˆμ–΄ λŒ€μ²΄λ‘œ 완성도 λ†’μ§€λ§Œ κ΄€λ ¨ μ΄μŠˆμ™€ 특이 사항은 λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/current-term-empty-universities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@manNomi

manNomi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

πŸ“Έ Before / After

Before (κ·ΈλΌλ°μ΄μ…˜ μ—†μŒ)

before

After (κ·ΈλΌλ°μ΄μ…˜ 적용)

after


λ³€κ²½ 사항

  • inset-0 rounded-lg β†’ bottom-0 inset-x-0 h-full rounded-b-lg (ν•˜λ‹¨λ§Œ border-radius)
  • gradient λ°©ν–₯: to bottom β†’ 180deg (Figma CSS κ·ΈλŒ€λ‘œ 반영)
  • gradient κ°’: linear-gradient(180deg, rgba(255, 255, 255, 0.00) 0%, rgba(0, 0, 0, 0.35) 75%, rgba(0, 0, 0, 0.70) 100%)

@manNomi

manNomi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

πŸ“Έ Before / After (μ΅œμ’…)

Before

before

After (ν•˜λ‹¨ h-1/2 μ˜μ—­μ—λ§Œ κ·ΈλΌλ°μ΄μ…˜)

after

This branch was successfully deployed

3 active deployments
Preview – solid-connect-web-admin β€” 3063004b Deployed Jul 24, 2026 by vercel[bot]
Preview – solid-connection-web β€” 3063004b Deployed Jul 24, 2026 by vercel[bot]
Preview – solid-connect-university-web β€” 3063004b Deployed Jul 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant