Skip to content

[android][ios] German localization - #234

Open
wpmed92 wants to merge 2 commits into
mainfrom
localize-de
Open

wpmed92 wants to merge 2 commits into
mainfrom
localize-de

Conversation

@wpmed92

@wpmed92 wpmed92 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Needs proofreading

<string name="settings_render_low">Niedrig</string>
<string name="settings_render_med">Mittel</string>
<string name="settings_render_high">Hoch</string>
<string name="settings_toggle_extra_vehicle_bus">Zusätzlicher Fahrzeugbus</string>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this should be explained to a user. A normal user will not know what this means.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of simply removing it. Nobody is using with the comma extra bus anyways, since most of those users are already on DashKit.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we auto detect it? If the data is coming through, add it to the dashboard. Then you can remove all the toggles related to it.

<string name="settings_render_med">Mittel</string>
<string name="settings_render_high">Hoch</string>
<string name="settings_toggle_extra_vehicle_bus">Zusätzlicher Fahrzeugbus</string>
<string name="settings_vehicle_bus_requires_extra">Aktiviere den zusätzlichen Fahrzeugbus, um diese zu bearbeiten.</string>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the context of where this would appear, but it likely doesn't make sense.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it, or at least hide every "Extra vehicle bus" stuff behind the debug flag. Nobody is using this.

Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated
Comment thread dashpilot-android/app/src/main/res/values-de/strings.xml Outdated

<!-- Data source menu -->
<string name="data_source">Datenquelle</string>
<string name="data_source_connected">Datenquelle: verbunden</string>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is connected? A Comma device, or a Dashkit?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raudi1 Do you mean that we should show what device is connected?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should say Dashkit connected for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants