Repository navigation
Run on the Node 24 runtime - #2
Merged
Merged
Conversation
GitHub deprecated Node 20 on Actions runners, and this action still declared node16, so every consumer saw a deprecation warning and the runner force-ran it on node24 anyway. Declaring node24 makes that explicit and silences the warning. dist/ is deliberately not rebuilt. The committed ncc bundle is CommonJS targeting es6, which node24 runs as-is: executed under node v24.14.0 it loads and reaches getPRDetails, failing only on the absent GITHUB_EVENT_PATH, with no module or syntax error. Rebuilding would drift every bundled dependency for no gain here. Requires Actions runner v2.327.1 or later on self-hosted runners. Known cosmetic issue, unchanged by this commit: a transitive dependency triggers DEP0040 (the punycode deprecation warning) on node24. It is a warning only; clearing it means a dependency bump, which belongs in its own change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub deprecated Node 20 on Actions runners. This action still declared
node16, so every consumer saw a deprecation warning while the runner force-ran it on node24 regardless. Declaringnode24makes that explicit and silences the warning.Consumed by
softagram/softagram-liveviasoftagram/ai-codereviewer@main, so this takes effect there as soon as it merges — no pin bump needed on that side.dist/ is deliberately not rebuilt
The committed
nccbundle is CommonJS targeting es6, which node24 runs as-is. Verified under node v24.14.0: it loads and reachesgetPRDetails, failing only on the absentGITHUB_EVENT_PATH— no module or syntax error. Rebuilding would drift every bundled dependency (openai, @octokit/rest, minimatch) for no benefit to this change.Known, unchanged
A transitive dependency triggers
DEP0040(punycode deprecation) on node24. Warning only; clearing it means a dependency bump and belongs in its own PR.Requires Actions runner v2.327.1+ on self-hosted runners.