Remove misleading payload signing performance warnings - #778
Open
jonathan343 wants to merge 1 commit into
Open
Conversation
Payload signing is enabled by default and the warning is emitted for every non-empty request body, including small requests where the performance impact is negligible. Remove the noisy warning from both synchronous and asynchronous signers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
AWSSDKWarningemissions from the synchronous and asynchronous SigV4 signers when hashing request payloads.Payload signing is enabled by default, and the warning was emitted for every non-empty request body regardless of size. This made normal SDK operations, including small STS requests, produce a noisy and non-actionable warning.
Payload signing behavior remains unchanged and only the warning is removed. Tests are updated accordingly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.