Prevent Java builds from silently reformatting source files - #772
Open
jonathan343 wants to merge 2 commits into
Open
Prevent Java builds from silently reformatting source files#772jonathan343 wants to merge 2 commits into
jonathan343 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our Java formatting check currently rewrites files before validating them. Because
spotlessCheckinvokesspotlessApply,make build-javasilently fixes formatting errors and CI passes. This allows unformatted code to reachdevelop, causing unrelated formatting changes to appear in later PRs.This PR separates formatting from validation so builds and CI fail on unformatted code without modifying source files. It also adds explicit formatting commands and applies the outstanding formatting fixes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.