Repository navigation
Support non-rewindable Rack inputs for Events signature verification - #607
Merged
Merged
Conversation
dblock
force-pushed
the
events-non-rewindable-input
branch
from
October 5, 2026 13:08
a254ee8 to
a1ece3d
Compare
Danger ReportNo issues found. |
dblock
force-pushed
the
events-non-rewindable-input
branch
2 times, most recently
from
October 5, 2026 13:11
5703680 to
22e28bc
Compare
Follow up on slack-ruby#515 with signature and WEBrick handler integration coverage for Rack 2 and Rack 3, plus middleware ordering documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
events-non-rewindable-input
branch
from
October 5, 2026 13:12
22e28bc to
05970c0
Compare
Coverage Report for CI Build 37315033686Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.1%) to 91.383%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Successor to #515, crediting @olleolleolle for the original conditional-rewind fix. Rack 3 no longer requires rack.input to implement rewind, and rackup/WEBrick exposes a non-rewindable stream.
No CI matrix changes, Rack version-selection scaffolding, or runtime dependency changes. Rackup and WEBrick are test-only dependencies.
Verification
27 Events examples pass with Rack 3.2.7 / rackup 2.3.1. Focused RuboCop passes. Existing local bigdecimal extension warnings remain unrelated.
AI-generated implementation and PR description by GitHub Copilot on behalf of @dblock.