Repository navigation
Add configured client copies with error callbacks - #606
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
client-error-callbacks
branch
from
October 5, 2026 12:57
395f0d2 to
44b9b17
Compare
Danger ReportNo issues found. |
Coverage Report for CI Build 37313179260Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.1%) to 91.288%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
client.with_error { |error| ... }, complementing the request and response observers introduced in #605.Error observers receive Slack, transport, and translated parsing exceptions for every failed HTTP attempt, including pagination retries. After notification the same exception is re-raised with its backtrace preserved. Exceptions from request/response callbacks are excluded. If an error observer raises, that exception propagates without recursive notification. Configured copies preserve the original client and support callback chaining.
Includes README usage and regression coverage. This provides centralized access to error details discussed in #483 without changing exception messages globally.
Validation: 642 non-CLI examples pass; RuboCop reports no offenses. CLI specs remain excluded locally because an existing Bundler missing-extension warning contaminates subprocess output. Existing submodule changes are excluded.
Prepared by an AI on behalf of @dblock.