Repository navigation
Remove obsolete JSON version pin from test bundle - #604
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danger ReportWarnings
MarkdownsHere's an example of a CHANGELOG.md entry: * [#604](https://github.com/slack-ruby/slack-ruby-client/pull/604): Remove obsolete json version pin from test bundle - [@dblock](https://github.com/dblock). |
Coverage Report for CI Build 37310328659Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 91.046%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the JSON < 3 constraint from the test bundle and its obsolete AGENTS.md guidance. Faraday 2.14.4 now passes parser options as keyword arguments, fixing compatibility with JSON 3. The existing runtime dependency minimum and supported Ruby matrix are unchanged.
Validated with Faraday 2.14.4 and JSON 3.0.2: 622 non-CLI specs pass, and RuboCop reports no offenses. The CLI spec file remains excluded locally because an existing Bundler missing-extension warning contaminates subprocess output. Existing local submodule changes are excluded.
Prepared by an AI on behalf of @dblock.