Skip to content

Enforce exception message conventions and run lint separately - #603

Merged
dblock merged 1 commit into
slack-ruby:masterfrom
dblock:add-exception-message-cops
Oct 5, 2026
Merged

dblock merged 1 commit into
slack-ruby:masterfrom
dblock:add-exception-message-cops

Conversation

@dblock

@dblock dblock commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add rubocop-exception_messages and modern RuboCop to the main Gemfile, conditionally on Ruby 3.2+. No separate Gemfile.
  • Run lint in the dedicated Ruby 3.3 job and tests across the unchanged supported-Ruby matrix. Default rake runs specs only.
  • Correct exception messages and regression expectations, excluding generated API code.
  • Run rubocop -a once and retain safe corrections; baseline only three remaining unrelated offenses.
  • Add Enforce exception message conventions and run lint separately #603 to CHANGELOG and document workflow conventions in AGENTS.md.

Validation

  • RuboCop: 75 files, no offenses.
  • Specs excluding the CLI file: 619 examples, no failures.
  • Ruby 2.7 Gemfile evaluation excludes all lint dependencies.
  • Four CLI cases previously failed locally because an existing missing-bigdecimal-extension Bundler warning contaminates subprocess output.
  • Existing local slack-api-ref submodule changes are excluded.

Prepared by an AI on behalf of @dblock.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Danger Report

No issues found.

View run

@dblock
dblock force-pushed the add-exception-message-cops branch from ab6f19b to bc56eea Compare October 5, 2026 12:20
@dblock dblock changed the title Enforce exception message conventions with a separate lint bundle Enforce exception message conventions and run lint separately Oct 5, 2026
@dblock
dblock force-pushed the add-exception-message-cops branch 2 times, most recently from eab6ac5 to 57e422b Compare October 5, 2026 12:27
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock force-pushed the add-exception-message-cops branch from 57e422b to 8e23289 Compare October 5, 2026 12:29
@dblock
dblock merged commit 7ed5d09 into slack-ruby:master Oct 5, 2026
10 checks passed
@dblock
dblock deleted the add-exception-message-cops branch October 5, 2026 12:31
@coveralls

coveralls commented Oct 5, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 37309723822

Coverage decreased (-0.003%) to 91.046%

Details

  • Coverage decreased (-0.003%) from the base build.
  • Patch coverage: 4 uncovered changes across 3 files (31 of 35 lines covered, 88.57%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
spec/slack/web/api/mixins/users_spec.rb 4 2 50.0%
lib/slack/web/api/mixins/users.search.rb 1 0 0.0%
spec/slack/web/api/endpoints/custom/auth_spec.rb 1 0 0.0%
Total (14 files) 35 31 88.57%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 5997
Covered Lines: 5460
Line Coverage: 91.05%
Coverage Strength: 100.5 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants