Repository navigation
v7.16.1: Déjà Vu no longer counts common English words - #28
Merged
Merged
Conversation
One imprinted English sentence made every unrelated English question "familiar" through the/about/what/talked. scent() now skips English function words, contraction stems, the most common verbs and recall-frame words; Chinese tokenization is unchanged. - bench section E2 (English): unrelated questions falsely familiar 6/6 -> 0/6, related questions still familiar 3/3 - benchmarks/dejavu_english_real.py on LongMemEval-S user turns: 20 turns 10/10 -> 0/10, 200 turns 10/10 -> 3/10, 2000 turns 10/10 -> 10/10 (ordinary content words); the remaining limit is documented - bump to 7.16.1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ZZeQFn5F6mEbmX8vPsf4g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Déjà Vu's tokenizer treated every English word of 3+ letters as a token. That included the, what, about, you, talked. Once a single English memory was imprinted, any unrelated English question came back "familiar". For example,
sense("that quantum computing paper we talked about")said familiar because of about and that. The orchestrator then turned those words into[known entity] aboutrecall candidates.Change
scent()now skips a short list of English common words:A capitalised phrase made only of such words ("What About") is skipped too. may stays a token, since it is also the month. Chinese tokenization is unchanged: the Chinese benchmark results and the tokenizer baseline are identical to v7.16.0.
No migration is needed. Words imprinted by older versions stay in Veil / Mist, but
imprintandsensenever produce them any more, so they are never probed.Measured
benchmarks/dejavu_bench.py, new section E2:hunt()still finds the target: 3/3.benchmarks/dejavu_english_real.py(new), on LongMemEval-S user turns with 10 unrelated questions:Not fixed (documented)
With a long history, ordinary content words like teacher and workshop have all been seen.
familiaris true as soon as one content word has been seen, so those questions still come back familiar. This is how the design works, not a tokenizer bug. It is now point 6 of "What it is not" indocs/dejavu.mdand its Chinese version, and it is in the README's known limitations.Validation
tests/test_dejavu.py:Generated by Claude Code