Return selected sequence reference from GetInitialGuess and remove copy-based test - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GetInitialGuessto avoid unnecessary copying and to match the updated documentation.GetInitialGuessreturned a copy because the intended behavior is now to return the original sequence.Description
DtwBarycenterAveraging.GetInitialGuessto returnsourceSequences[bestIndex]instead of creating and returning a copied array ofVec<double>instances.GetInitialGuessSelectsMedoidWithSmallestTotalDtwDistancetest fromDtwBarycenterAveragingTestswhich asserted the returned sequence was not the same instance as the source.Testing
NumFlatTestunit test suite withdotnet test, and the tests passed.FitMatchesTslearnDocumentedExampleWithEqualLengthSeries,FitKeepsInitialGuessLengthForDifferentLengthSeries,UpdateDoesNotIncreaseObjectiveCost, andSingleSourceSequenceIsReturnedUnchangedByFitall completed successfully.Codex Task