-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(db): index large-value workflow_id FKs so workflow deletes don't seq-scan #6136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+18,344
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| -- Both tables carry `workflow_id ... ON DELETE SET NULL` (migration 0212) with no index leading | ||
| -- on that column. Postgres implements SET NULL as an AFTER ROW referential trigger running | ||
| -- `UPDATE ... SET workflow_id = NULL WHERE workflow_id = $1` once per deleted parent row, so | ||
| -- every `DELETE FROM workflow` sequentially scans both tables per workflow — enough to blow the | ||
| -- statement timeout once the soft-delete retention job starts hard-deleting archived workflows. | ||
| -- Both indexes exist to make that trigger index-driven. | ||
| -- | ||
| -- Replay-safety: this file is only CONCURRENTLY index builds below an embedded COMMIT, so a | ||
| -- failure replays the whole file — both statements are idempotent. | ||
| COMMIT;--> statement-breakpoint | ||
| SET lock_timeout = 0;--> statement-breakpoint | ||
| CREATE INDEX CONCURRENTLY IF NOT EXISTS "execution_large_value_references_workflow_id_idx" ON "execution_large_value_references" USING btree ("workflow_id");--> statement-breakpoint | ||
| CREATE INDEX CONCURRENTLY IF NOT EXISTS "execution_large_values_workflow_id_idx" ON "execution_large_values" USING btree ("workflow_id");--> statement-breakpoint | ||
| SET lock_timeout = '5s'; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When either concurrent build fails after creating its catalog entry, the replayed
IF NOT EXISTSstatement skips the resulting INVALID index, allowing the migration to complete while workflow deletions continue sequentially scanning the corresponding large-value table.Knowledge Base Used: Database schema and migrations (
packages/db)