-
Notifications
You must be signed in to change notification settings - Fork 3.7k
improvement(workflow): polish canvas interactions and execution states #5976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andresdjasso
wants to merge
7
commits into
staging
Choose a base branch
from
workflow-updates
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
794ab14
improvement(workflow): refine canvas interactions and rendering
andresdjasso 67cf78d
fix(workflow): keep outputs on the right, focus newly created blocks
andresdjasso 41452a3
fix(workflow): floor header-only card height, adopt brand tag palette
andresdjasso abf8385
improvement(workflow): polish workflow canvas interactions
andresdjasso 1422c5c
fix(workflow): restyle loop drop target outline
andresdjasso 3a8840e
fix(workflow): shorten human block catalog label
andresdjasso 7f6cc9c
fix(workflow): canonicalize realtime edge handles
andresdjasso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error toggle lost on replace
Medium Severity
UPDATE_ERROR_ENABLEDpersistserrorEnabledinto blockdata, but the client store only updates the top-level field andREPLACE_STATErewrites blocks fromblock.dataalone without merging that top-level value the way full saves do. After undo/redo or any replace-state, a later reload can drop an enabled error output that has no error edge yet.Additional Locations (1)
apps/realtime/src/database/operations.ts#L2170-L2187Reviewed by Cursor Bugbot for commit 7f6cc9c. Configure here.