Skip to content

Notification channels - #379

Merged
hamzahalq merged 26 commits into
releases/r10.0-developfrom
hamza/feature/notification-channels
Oct 13, 2026
Merged

hamzahalq merged 26 commits into
releases/r10.0-developfrom
hamza/feature/notification-channels

Conversation

@hamzahalq

@hamzahalq hamzahalq commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Notifications and alerts go through notification channels, set up once in Settings: Email (through one mail server set in Settings), Microsoft Teams, Slack, or any adapter.

  • Subscriptions pick channels and when each sends: Fails, Bad result, Succeeds, Goes quiet. One message per outage, up to three tries, the per-destination circuit breaker, and no double send on redelivery.
  • Retry-budget, auto-pause and quiet/back alerts go through channels. Existing retry alerts with their own handler are moved onto channels on first start, safely with two replicas.
  • Legacy notifiers keep running, off the sidebar. bitween apply gains notificationChannels, retry alertChannel and subscription notifications.
  • Also fixes: subscription Update kept a secret across an adapter change, and a result for a just-switched-off subscription crashed the notifier.
  • Reviewed by area, since CodeRabbit skipped the size. The last 11 commits are its fixes. Among them: alerts no longer suppress a channel's own failure message; secret names now match ignoring case, so a stored password can't be sent to a new host; and a shared channel's quiet-window lookup went from 3.2 s to 17 ms. Members and Viewers now see the channel list in Settings.
  • Tested: unit, integration, transport and e2e (the 2 e2e failures fail on develop too), plus the upgrade from develop with two replicas and live runs on PostgreSQL, MySQL and SQL Server.
  • Found on develop, not changed here: retry policies with matchers can't be saved on MySQL or SQL Server, and two copies creating a new MySQL database at once crash the second (Program.cs reads the connection string as Npgsql).

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (8)
  • ^main$
  • ^master$
  • ^staging$
  • ^development$
  • ^gigstaging$
  • ^develop$
  • ^releases$
  • ^releases/r10.0$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: simplify9/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4fd52187-4b16-495f-a8a6-2be3c0fc754e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hamzahalq
hamzahalq merged commit 6ce1de0 into releases/r10.0-develop Oct 13, 2026
3 checks passed
@hamzahalq
hamzahalq deleted the hamza/feature/notification-channels branch October 13, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants