Repository navigation
fix: support fullscreen agent input and voice workflows - #97
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fullscreen terminal applications could not receive Shift-modified mouse input or Cmd+C when Noa had no selection. This adds XTSHIFTESCAPE support and a
mouse-shift-capturesetting, and forwards Cmd+C to fullscreen applications that negotiate the Kitty keyboard protocol while preserving Noa selection priority.Output Snapshot now explains that alternate-screen captures contain only the current screen. macOS bundles include the microphone usage description and audio-input entitlement needed by voice-capable terminal applications. The workflow guide documents fullscreen history controls and the Antigravity SSH graphics workaround.
Reviewer notes:
mouse-shift-capture = truefor applications that do not request Shift capture themselves. The default remainsfalse; application requests overridefalse/true, whilealways/neverforce the policy. Requests survive remote client seed replay and reset on RIS.Validation:
cargo test --workspace: 2,701 passed, 0 failed, 15 ignored.cargo build --workspace,cargo fmt --all --check, andgit diff --checkpassed.scripts/bundle-macos.sh debugbuilt the app;codesign --verify --deep --strictpassed. The generated usage description and signed audio-input entitlement were checked.bash -n scripts/bundle-macos.shand entitlement plist validation passed.Limitations:
CLI_GRAPHICS=kitty agyas a workaround.