Repository navigation
feat(app): auto-approve agy subagent approval notices - #104
Merged
Merged
Conversation
agy shows a barred notice above its input box when a subagent waits on a
tool approval ("<agent> needs approval for <Tool>" ... "ctrl+k approve ·
alt+j manage"). Recognize it and answer with ctrl+k.
The notice is matched only as a whole: every row behind one left bar, a
rule, a "● <Tool>(…)" call naming the title's tool, and the hint naming
ctrl+k, followed by agy's live frame: a rule, an empty input prompt, a
rule, only subagent list rows, and the status bar last. ctrl+k is also a
line edit, so a draft in the input leaves the screen to the user; a
multi-line draft can paint its own rule under an empty first line, which
is why every row down to the status bar must be a list row. A rebound
approve key or a second notice is left to the user too. The command
denylist applies to the displayed call, and the dialog hash stops at the
hint so the subagent list's timers do not rearm it.
agy's status bar check now accepts any upper-case mode label (IDLE as
well as TOOL USE), which also applies to the existing agy dialogs.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subagent waits on a tool approval, agy shows a notice above its input box (
<agent> needs approval for <Tool>…ctrl+k approve · alt+j manage) instead of its permission menu, so auto-approve left those runs stalled. This PR recognizes that notice and answers it with ctrl+k (0x0b).The notice is matched only as a whole:
● <Tool>(…)call naming the title's tool, and a hint that names ctrl+k.>input prompt, a rule, only subagent list rows (● Agent(…)), and agy's status bar last.Reviewer notes:
agy_status_rownow accepts any upper-case mode label (IDLEas well asTOOL USE) before| Model | … | Context: n%. This also slightly loosens the live-tail check of the existing agy command and question dialogs.│ ┃ ▌ ▎are all accepted. A different glyph only means no match.subagent.approve_fast/ "Approve subagent fast" binding and has not been observed.Validation:
0x0b, that a ticking subagent timer does not rearm it, and that it decodes from a VT grid.(+1 more)title.cargo test --workspace --no-fail-fastpasses: 2822 tests, run unsandboxed fornoa-pty/noa-ipc.cargo fmt --checkandgit diff --checkpass.cargo clippy -p noa-app --all-targetsreports nothing inauto_approve.rs. Warnings that already existed in other files remain.Not addressed: