Fix default model options when constructing Prompt directly - #1663
Open
oodadoudou wants to merge 1 commit into
Open
Fix default model options when constructing Prompt directly#1663oodadoudou wants to merge 1 commit into
oodadoudou wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly constructing
llm.Prompt("hello", model)leavesprompt.optionsas a dict. Providers that access option attributes then raiseAttributeError; this also reproduces with the built-in OpenAI Responses provider on current main.Use the model's
Options()for the existing empty/default fallback. Explicit Options instances remain unchanged. Four regression cases exercise the public Prompt/Response path using the existing mocked HTTP response fixture: omitted options,None, an empty dict, and a populated Options instance.Fixes #1028.
Validation (Python 3.12.9):
prompt.options.json_object; the explicit-options control passes. After the fix, all 13 options tests pass.httpx2-pytest==1.0.1: version 2.0.0 renames thehttpx_mockfixture required by the existing suite. No dependency files changed.docs/fragments.md(0.33) versuspyproject.toml(0.34), also present on the base commit2f49eec9.Implemented and tested with Codex assistance.