Repository navigation
Update font mapping script to support Noto TTF fonts - #4198
Merged
Merged
Conversation
Nateowami
added
testing not required
ai-review-author-sign-off
Nateowami
marked this pull request as ready for review
October 16, 2026 23:41
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4198 +/- ##
=======================================
Coverage 81.21% 81.21%
=======================================
Files 670 670
Lines 42912 42912
Branches 7105 7081 -24
=======================================
Hits 34853 34853
- Misses 6894 6911 +17
+ Partials 1165 1148 -17 ☔ View full report in Codecov by Harness. |
pmachapman
force-pushed
the
gha/fix-font-update-ttf
branch
from
October 18, 2026 21:24
02ea4bb to
76349ad
Compare
pmachapman
approved these changes
Oct 18, 2026
pmachapman
left a comment
pmachapman
left a comment
Collaborator
There was a problem hiding this comment.
@pmachapman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears Noto is no longer publishing OTF when they publish a new release of a font. The current script only looks for OTF, so this results in fonts getting dropped from the list of supported fonts.
This PR updated the script to fall back to TTF when OTF is not available. OTF tends to be a lot smaller, hence keeping it as default.
This change is