[Nateowami]

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.22%. Comparing base (7c55eea) to head (2964e9e).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...pp/checking/checking/checking-questions.service.ts	94.44%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4197   +/-   ##
=======================================
  Coverage   81.21%   81.22%           
=======================================
  Files         670      670           
  Lines       42912    42922   +10     
  Branches     7105     7112    +7     
=======================================
+ Hits        34853    34863   +10     
- Misses       6894     6910   +16     
+ Partials     1165     1149   -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[pmachapman]

Just one question!

@pmachapman reviewed 10 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking-questions.service.ts line 232 at r1 (raw file):

    const notDeleted: PropertyFilter = { [obj<Answer>().pathStr(a => a.deleted)]: { $ne: true } };
    const ownedByUser: PropertyFilter = { ...notDeleted, [obj<Answer>().pathStr(a => a.ownerRef)]: userId };
    const statusPath: string = obj<Answer>().pathStr(a => a.status);

Should we add indexes to these fields?

Code quote:

    const notDeleted: PropertyFilter = { [obj<Answer>().pathStr(a => a.deleted)]: { $ne: true } };
    const ownedByUser: PropertyFilter = { ...notDeleted, [obj<Answer>().pathStr(a => a.ownerRef)]: userId };
    const statusPath: string = obj<Answer>().pathStr(a => a.status);

[pmachapman]

@pmachapman made 1 comment and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

---

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking-questions.service.ts line 232 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Should we add indexes to these fields?

As discussed, there should be no need for indexes, as the filters that select these are not often used.