Repository navigation
Update dependencies and unit tests to new NUnit API - #1057
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
==========================================
+ Coverage 72.83% 72.87% +0.03%
==========================================
Files 391 391
Lines 21793 21792 -1
Branches 2836 2814 -22
==========================================
+ Hits 15873 15880 +7
+ Misses 4791 4781 -10
- Partials 1129 1131 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
48268b5 to
e134751
Compare
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 44 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/Machine/test/Serval.Machine.Translation.Tests/Services/EchoTranslationEngineServiceTests.cs line 61 at r1 (raw file):
} [Test]
Wasn't this intentionally left off since it's flaky? #1008
e134751 to
c9feabe
Compare
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: 38 of 44 files reviewed, 1 unresolved discussion (waiting on Enkidu93).
src/Machine/test/Serval.Machine.Translation.Tests/Services/EchoTranslationEngineServiceTests.cs line 61 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Wasn't this intentionally left off since it's flaky? #1008
Done. I have removed it - it seemed non-flaky in my tests, but I will leave it to the other issue that deals with all of these DeleteAsync_WhileBuilding tests.
03f3f4c to
b23603d
Compare
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: 43 of 44 files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/Machine/test/Serval.Machine.Translation.Tests/Services/EchoTranslationEngineServiceTests.cs line 61 at r1 (raw file):
Previously, pmachapman (Peter Chapman) wrote…
Done. I have removed it - it seemed non-flaky in my tests, but I will leave it to the other issue that deals with all of these
DeleteAsync_WhileBuildingtests.
Sounds good.
a0e1cda to
f2795f8
Compare
f2795f8 to
ccfc0c8
Compare
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman resolved 1 discussion and dismissed @Enkidu93 from a discussion.
Reviewable status: 37 of 44 files reviewed, all discussions resolved (waiting on Enkidu93).
This PR update dependencies to their latest versions. The only real change was to the
Assert.ThrowsAsyncandAssert.DoesNotThrowAsyncfunctions, which resulted in async/await changes to a lot of API integration unit tests.This change is