Skip to content

Update dependencies and unit tests to new NUnit API - #1057

Merged
pmachapman merged 1 commit into
mainfrom
update_dependencies
Oct 7, 2026
Merged

pmachapman merged 1 commit into
mainfrom
update_dependencies

Conversation

@pmachapman

@pmachapman pmachapman commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

This PR update dependencies to their latest versions. The only real change was to the Assert.ThrowsAsync and Assert.DoesNotThrowAsync functions, which resulted in async/await changes to a lot of API integration unit tests.


This change is Reviewable

@pmachapman
pmachapman requested a review from Enkidu93 October 1, 2026 00:18
@codecov-commenter

codecov-commenter commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.87%. Comparing base (0cc5e20) to head (ccfc0c8).

Files with missing lines Patch % Lines
...c/Serval.Machine.Shared/Services/ClearMLService.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
+ Coverage   72.83%   72.87%   +0.03%     
==========================================
  Files         391      391              
  Lines       21793    21792       -1     
  Branches     2836     2814      -22     
==========================================
+ Hits        15873    15880       +7     
+ Misses       4791     4781      -10     
- Partials     1129     1131       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman
pmachapman force-pushed the update_dependencies branch 4 times, most recently from 48268b5 to e134751 Compare October 1, 2026 01:49

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enkidu93 reviewed 44 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/Machine/test/Serval.Machine.Translation.Tests/Services/EchoTranslationEngineServiceTests.cs line 61 at r1 (raw file):

    }

    [Test]

Wasn't this intentionally left off since it's flaky? #1008

@pmachapman
pmachapman force-pushed the update_dependencies branch from e134751 to c9feabe Compare October 1, 2026 19:33
@pmachapman
pmachapman requested a review from Enkidu93 October 1, 2026 19:35

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment.
Reviewable status: 38 of 44 files reviewed, 1 unresolved discussion (waiting on Enkidu93).


src/Machine/test/Serval.Machine.Translation.Tests/Services/EchoTranslationEngineServiceTests.cs line 61 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

Wasn't this intentionally left off since it's flaky? #1008

Done. I have removed it - it seemed non-flaky in my tests, but I will leave it to the other issue that deals with all of these DeleteAsync_WhileBuilding tests.

@pmachapman
pmachapman force-pushed the update_dependencies branch 2 times, most recently from 03f3f4c to b23603d Compare October 5, 2026 21:01

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: 43 of 44 files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/Machine/test/Serval.Machine.Translation.Tests/Services/EchoTranslationEngineServiceTests.cs line 61 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Done. I have removed it - it seemed non-flaky in my tests, but I will leave it to the other issue that deals with all of these DeleteAsync_WhileBuilding tests.

Sounds good.

@pmachapman
pmachapman force-pushed the update_dependencies branch 3 times, most recently from a0e1cda to f2795f8 Compare October 6, 2026 01:42
@pmachapman
pmachapman force-pushed the update_dependencies branch from f2795f8 to ccfc0c8 Compare October 7, 2026 18:09
@pmachapman
pmachapman requested a review from Enkidu93 October 7, 2026 18:17

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman resolved 1 discussion and dismissed @Enkidu93 from a discussion.
Reviewable status: 37 of 44 files reviewed, all discussions resolved (waiting on Enkidu93).

@pmachapman
pmachapman merged commit 73f032f into main Oct 7, 2026
1 of 2 checks passed
@pmachapman
pmachapman deleted the update_dependencies branch October 7, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants