Repository navigation
TT-7122 include General projects in burrito content folders - #748
Merged
Merged
Conversation
added 3 commits
October 8, 2026 14:36
## Summary - The Books step now records a General project's book key from its project default when no passage has a book, so that key is saved with the Scripture books. - Audio, Text, Resources, Navigation, and Notes create a folder per saved book, so the General project is included there. Apm Data already included both projects by name. - A Burrito Books component test selects a Scripture project (Genesis) and a General project whose passages have no book, and requires both names under Selected Books. ## Test plan - [ ] Export a burrito with both a Scripture project and a General project, and with Audio, Text, Resources, Navigation, Notes, and Apm Data selected. - [ ] Apm Data still shows both project folders. - [ ] Audio, Text, Resources, Navigation, and Notes each include the General book folder as well as the Scripture book folder.
- Added the collectBurritoBooks function to aggregate book keys from projects, plans, sections, and passages, prioritizing passage book values and falling back to project defaults when necessary. - Updated the BurritoBooks component to utilize the new function for collecting and sorting book keys based on selected projects. - Enhanced tests for collectBurritoBooks to cover various scenarios, including handling multiple books in a project and using project defaults when no passage book is present.
…lution - Changed the moduleResolution setting in tsconfig.jest.json from 'node' to 'bundler' to align with the current project requirements.
gtryus
marked this pull request as draft
October 13, 2026 18:02
- Updated the projectDefaultToBurritoBookKey function to retain project-sort general keys, ensuring they are not mapped to scripture. - Added tests to verify that general project keys are correctly handled in both the project default and the collectBurritoBooks function. - Modified the BurritoBooks component to utilize the updated logic for displaying project keys, including general projects in the selection process. - Enhanced the useCreateBurrito hook to include general project sections in the Notes export when the book default is a project-sort key.
gtryus
marked this pull request as ready for review
October 13, 2026 18:44
sarahentzel
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan