[2/2] feat: deprecate the Mux and TikTok destinations - #153
Merged
Merged
Conversation
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mux and TikTok are no longer promoted as destinations, and the guide has already dropped their pages, but the spec still presented both as current. This marks
MuxDestination,MuxDestinationOptions,TiktokDestinationandTiktokDestinationOptionsasdeprecated: true, each with a notice in the same form asSoundtrack's. Two descriptions that named Mux as an example destination now name a live one; the second also listed YouTube, which isn't a destination.Nothing is removed: both destinations still validate and still work. Published package: zod export names are unchanged, the generated code differs only in doc comments, and
schema.d.tsgains@deprecatedtags. A deprecation is a minor change under SemVer, so this is afeat:, and merging releases 1.21.0.Merge with a merge commit, not a squash, so the
feat:and #152'sfix:both reach the release notes.Verify: after
pnpm build,destinationsSchemastill accepts{ "provider": "mux" }and{ "provider": "tiktok" }; afterpnpm build:docs, the reference shows both notices.Stack (merge in order)