Repository navigation
Add GitHub Pages site and social card - #2
Conversation
- site/index.html: one static page. A sketch picker mirrors the skill's flow (greyscale first, colour and kit after you choose), plus how it works, kit contents, merch by business type, install options, limits and credits - .github/workflows/pages.yml: assembles the page and the example previews it shows, then deploys with the official Pages actions (needs Pages source set to GitHub Actions) - tools/make_social_card.py and site/social-card.png: social preview at 1280x640 inside an 80 px safe area (69 KB) - README links to the site; .gitignore ignores a local _site build Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14ea97c628
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please focus on: the Pages workflow (permissions, the assemble step, and whether every file the page references is packaged), accessibility and robustness of |
The "Codex, Gemini or another agent" block only showed --codex, which installs under ~/.codex only. It now lists --codex, --gemini and --dest for other agents. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14ea97c628
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r.addEventListener("change", function () { if (r.checked) show(r.value); }); | ||
| }); | ||
| document.querySelectorAll(".cmd").forEach(function (pre) { | ||
| var btn = el("button", { "class": "copy", type: "button", "aria-label": "Copy to clipboard" }, "Copy"); |
There was a problem hiding this comment.
For screen-reader users, all three controls have the identical accessible name “Copy to clipboard,” so button-list or quick-navigation users cannot determine whether a control copies the Claude command, installer command, or agent prompt. The fixed aria-label also overrides the changing button text, so the later “Copied” state is not exposed; derive the name from the associated block and expose the result as an announced status.
Useful? React with 👍 / 👎.
| if (navigator.clipboard && navigator.clipboard.writeText) { navigator.clipboard.writeText(text).then(done, done); } | ||
| else { var t = document.createElement("textarea"); t.value = text; document.body.appendChild(t); t.select(); try { document.execCommand("copy"); } catch (e) {} document.body.removeChild(t); done(); } |
There was a problem hiding this comment.
When navigator.clipboard.writeText() rejects—for example because clipboard permission is denied—the rejection callback is also done, so the button claims “Copied” even though the clipboard remains unchanged. The fallback likewise calls done() after an exception or a false execCommand() result; attempt the fallback on rejection and show success only after a confirmed copy.
Useful? React with 👍 / 👎.
What this adds
site/index.html: a single static page for GitHub Pages. Its centrepiece is a sketch picker that mirrors the skill's flow: three greyscale sketches, and only the one you pick turns to colour and shows its kit (real mockups fromexamples/). Then how it works, kit contents, merch by business type, install options (Claude Code, other agents, copy-paste prompt), limits and credits..github/workflows/pages.yml: assembles the page plus the example previews it shows (about 5 MB) and deploys with the official Pages actions.site/social-card.png(1280×640, 69 KB) andtools/make_social_card.pyto regenerate it. All content sits inside an 80 px safe area..gitignoreignores a local_site/build.Checked
Needed before it goes live
Repo Settings → Pages → Build and deployment → Source: GitHub Actions. After that the workflow publishes to https://shadowtor.github.io/BrandDesign/ on merge.
Social preview for the repo itself is a manual upload (Settings → General → Social preview →
site/social-card.png); GitHub has no API for it.🤖 Generated with Claude Code